-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a metadata file to KubeHound dumps #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edznux-dd
commented
Sep 6, 2024
edznux-dd
commented
Sep 6, 2024
edznux-dd
commented
Sep 6, 2024
edznux-dd
commented
Sep 6, 2024
edznux-dd
commented
Sep 6, 2024
edznux-dd
commented
Sep 6, 2024
} | ||
|
||
func (d *MetadataIngestor) DumpMetadata(ctx context.Context, metadata collector.Metadata) error { | ||
data := make(map[string]*collector.Metadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected that this is a pointer to the collector metadata ? 😅
The buffer above is make(map[string]collector.Metadata),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no it is not 😅
jt-dd
approved these changes
Sep 10, 2024
jt-dd
changed the title
[WIP] Moving to metadata file instead of meaningful filepath
Adding a metadata file to KubeHound dumps
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is barely a PoC.
TLDR:
To simplify user experience, especially for the local dumper/ingestor, we should write a
metadata.json
file that contains the metadata of a specific dump.Why:
Stuffing data in the filepath as some limitation:
How:
Add a
metadata.json
file that contains all the metadata around a specific dump.It will then be reused by the ingestor to populate the RunID, the ClusterName and any future info we want.